From: anish kumar Date: Wed, 20 Mar 2013 04:07:31 +0000 (+1100) Subject: kernel/watchdog.c: add comments to explain watchdog_disabled variable X-Git-Tag: next-20130320~2^2~326 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=6cdd33a36290320afdf4b23d1b6c536f1787355d;p=karo-tx-linux.git kernel/watchdog.c: add comments to explain watchdog_disabled variable This watchdog_disabled flag is a bit cryptic. However it's usefulness is multifold. Uses are: 1. Check if smpboot_register_percpu_thread function passed. 2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog Unlike enable watchdog->enable watchdog which is wrong. [dzickus@redhat.com: small text cleanups] Signed-off-by: anish kumar Signed-off-by: Don Zickus Signed-off-by: Andrew Morton --- diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 7672bef6c88b..ea741c32d596 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -521,6 +521,11 @@ int proc_dowatchdog(struct ctl_table *table, int write, return ret; set_sample_period(); + /* + * Watchdog threads shouldn't be enabled if they are + * disabled. The 'watchdog_disabled' variable check in + * watchdog_*_all_cpus() function takes care of this. + */ if (watchdog_enabled && watchdog_thresh) watchdog_enable_all_cpus(); else