From: Peter Hurley Date: Wed, 27 Mar 2013 10:57:40 +0000 (-0400) Subject: firewire: ohci: dump_stack() for PHY regs read/write failures X-Git-Tag: v3.10-rc1~37^2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=6fe9efb9c9fbce690018c31e652924ae28019868;p=karo-tx-linux.git firewire: ohci: dump_stack() for PHY regs read/write failures A stack trace is an invaluable tool in determining the basis and cause of PHY regs read/write failures. Include PHY reg addr (and value for writes) in the diagnostic. [Stefan R: changed whitespace] Signed-off-by: Peter Hurley Signed-off-by: Stefan Richter --- diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c index c64b4801adaa..9e1db6490b9a 100644 --- a/drivers/firewire/ohci.c +++ b/drivers/firewire/ohci.c @@ -572,7 +572,8 @@ static int read_phy_reg(struct fw_ohci *ohci, int addr) if (i >= 3) msleep(1); } - ohci_err(ohci, "failed to read phy reg\n"); + ohci_err(ohci, "failed to read phy reg %d\n", addr); + dump_stack(); return -EBUSY; } @@ -594,7 +595,8 @@ static int write_phy_reg(const struct fw_ohci *ohci, int addr, u32 val) if (i >= 3) msleep(1); } - ohci_err(ohci, "failed to write phy reg\n"); + ohci_err(ohci, "failed to write phy reg %d, val %u\n", addr, val); + dump_stack(); return -EBUSY; }