From: Greg Kroah-Hartman Date: Thu, 30 Apr 2015 09:33:00 +0000 (+0200) Subject: USB: ohci-hcd.c: move assignment out of if () block X-Git-Tag: v4.2-rc1~86^2~49 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=71f46340738322246285a40e25c1c3457a7d986b;p=karo-tx-linux.git USB: ohci-hcd.c: move assignment out of if () block We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman Reviewed-by: Felipe Balbi --- diff --git a/drivers/usb/host/ohci-hcd.c b/drivers/usb/host/ohci-hcd.c index 1dab9dfbca6a..760cb57e954e 100644 --- a/drivers/usb/host/ohci-hcd.c +++ b/drivers/usb/host/ohci-hcd.c @@ -155,7 +155,8 @@ static int ohci_urb_enqueue ( int retval = 0; /* every endpoint has a ed, locate and maybe (re)initialize it */ - if (! (ed = ed_get (ohci, urb->ep, urb->dev, pipe, urb->interval))) + ed = ed_get(ohci, urb->ep, urb->dev, pipe, urb->interval); + if (! ed) return -ENOMEM; /* for the private part of the URB we need the number of TDs (size) */