From: Vasu Dev <vasu.dev@intel.com>
Date: Fri, 7 May 2010 22:18:19 +0000 (-0700)
Subject: [SCSI] fcoe: fixes wrong error exit in fcoe_create
X-Git-Tag: v2.6.35-rc1~470^2^2~13
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=721cafafb66f57b461226aa197997f3e5b296f91;p=karo-tx-linux.git

[SCSI] fcoe: fixes wrong error exit in fcoe_create

fcoe_create exits using out_nodev label when module is not
yet LIVE but this exit path unlocks the rtnl_lock though
rtnl lock was not held in this case.

So this patch replaces out_nodev with out_nomod to exit
w/o unlocking rtnl_lock.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
---

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index aba839e68014..7022a16b14f6 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -2056,7 +2056,7 @@ static int fcoe_create(const char *buffer, struct kernel_param *kp)
 	 */
 	if (THIS_MODULE->state != MODULE_STATE_LIVE) {
 		rc = -ENODEV;
-		goto out_nodev;
+		goto out_nomod;
 	}
 #endif