From: Konstantin Khlebnikov <khlebnikov@openvz.org>
Date: Sun, 10 Jul 2011 12:13:27 +0000 (+0400)
Subject: kvm tools: fix instances enumeration
X-Git-Tag: next-20110824~3^2~124
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=737579f6b7e0653ecec7f09aea3b11ba67a69ccf;p=karo-tx-linux.git

kvm tools: fix instances enumeration

Calling readdir() with NULL dirp leads to segfault.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
[ penberg@kernel.org: use 'while' instead of 'for' ]
Signed-off-by: Pekka Enberg <penberg@kernel.org>
---

diff --git a/tools/kvm/kvm.c b/tools/kvm/kvm.c
index cd3cb1927733..a4a29b204af3 100644
--- a/tools/kvm/kvm.c
+++ b/tools/kvm/kvm.c
@@ -172,7 +172,7 @@ int kvm__enumerate_instances(void (*callback)(const char *name, int pid))
 	sprintf(full_name, "%s/%s", HOME_DIR, KVM_PID_FILE_PATH);
 	dir = opendir(full_name);
 
-	for (;;) {
+	while (dir != NULL) {
 		readdir_r(dir, &entry, &result);
 		if (result == NULL)
 			break;