From: Barry Song Date: Thu, 27 Sep 2012 08:36:10 +0000 (+0800) Subject: dmaengine: sirf: fix a typo in moving running dma_desc to active queue X-Git-Tag: v3.4.17~12 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=73cb40932358f82d55117a70a0d38026923e823f;p=karo-tx-linux.git dmaengine: sirf: fix a typo in moving running dma_desc to active queue commit 26fd12209c08fe947be1828896ef4ffc5bd0e6df upstream. list_move_tail(&schan->queued, &schan->active) makes the list_empty(schan->queued) undefined, we either should change it to: list_move_tail(schan->queued.next, &schan->active) or list_move_tail(&sdesc->node, &schan->active) Signed-off-by: Barry Song Signed-off-by: Vinod Koul Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/dma/sirf-dma.c b/drivers/dma/sirf-dma.c index 35a329da97fd..c4394892edab 100644 --- a/drivers/dma/sirf-dma.c +++ b/drivers/dma/sirf-dma.c @@ -109,7 +109,7 @@ static void sirfsoc_dma_execute(struct sirfsoc_dma_chan *schan) sdesc = list_first_entry(&schan->queued, struct sirfsoc_dma_desc, node); /* Move the first queued descriptor to active list */ - list_move_tail(&schan->queued, &schan->active); + list_move_tail(&sdesc->node, &schan->active); /* Start the DMA transfer */ writel_relaxed(sdesc->width, sdma->base + SIRFSOC_DMA_WIDTH_0 +