From: Eric Paris <eparis@redhat.com>
Date: Tue, 23 Nov 2010 23:18:37 +0000 (-0500)
Subject: inotify: stop kernel memory leak on file creation failure
X-Git-Tag: v2.6.34.14~62
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=74351de89460e502c99439c98dc134b7cf3c9a0e;p=karo-tx-linux.git

inotify: stop kernel memory leak on file creation failure

commit a2ae4cc9a16e211c8a128ba10d22a85431f093ab upstream.

If inotify_init is unable to allocate a new file for the new inotify
group we leak the new group.  This patch drops the reference on the
group on file allocation failure.

Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---

diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
index 0c6bbc031f15..72f882552608 100644
--- a/fs/notify/inotify/inotify_user.c
+++ b/fs/notify/inotify/inotify_user.c
@@ -674,6 +674,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags)
 	if (ret >= 0)
 		return ret;
 
+	fsnotify_put_group(group);
 	atomic_dec(&user->inotify_devs);
 out_free_uid:
 	free_uid(user);