From: Andy Shevchenko Date: Mon, 4 Mar 2013 09:09:26 +0000 (+0200) Subject: dmatest: allocate memory for pq_coefs from heap X-Git-Tag: next-20130404~73^2~1^2~20 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=76672b7e3bf28693224954519b89c778fbf7414b;p=karo-tx-linux.git dmatest: allocate memory for pq_coefs from heap This will help in future to hide a global variable usage. Signed-off-by: Andy Shevchenko Acked-by: Viresh Kumar Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index e6b4cfa1eb7f..e3955be2e3a4 100644 --- a/drivers/dma/dmatest.c +++ b/drivers/dma/dmatest.c @@ -278,7 +278,7 @@ static int dmatest_func(void *data) dma_cookie_t cookie; enum dma_status status; enum dma_ctrl_flags flags; - u8 pq_coefs[pq_sources + 1]; + u8 *pq_coefs = NULL; int ret; int src_cnt; int dst_cnt; @@ -302,10 +302,15 @@ static int dmatest_func(void *data) /* force odd to ensure dst = src */ src_cnt = min_odd(pq_sources | 1, dma_maxpq(dev, 0)); dst_cnt = 2; + + pq_coefs = kmalloc(pq_sources+1, GFP_KERNEL); + if (!pq_coefs) + goto err_thread_type; + for (i = 0; i < src_cnt; i++) pq_coefs[i] = 1; } else - goto err_srcs; + goto err_thread_type; thread->srcs = kcalloc(src_cnt+1, sizeof(u8 *), GFP_KERNEL); if (!thread->srcs) @@ -533,6 +538,8 @@ err_dsts: err_srcbuf: kfree(thread->srcs); err_srcs: + kfree(pq_coefs); +err_thread_type: pr_notice("%s: terminating after %u tests, %u failures (status %d)\n", thread_name, total_tests, failed_tests, ret);