From: Dave Jones Date: Sun, 28 Jan 2007 22:50:17 +0000 (-0500) Subject: [AGPGART] Remove pointless assignment. X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7707ea3b784195315366e6e4b5c73ca6933ff9b0;p=linux-beck.git [AGPGART] Remove pointless assignment. No point in clearing local pointers then returning. Also fix up some CodingStyle nits. Signed-off-by: Dave Jones --- diff --git a/drivers/char/agp/ati-agp.c b/drivers/char/agp/ati-agp.c index 0994d3534447..9987dc2e0c3f 100644 --- a/drivers/char/agp/ati-agp.c +++ b/drivers/char/agp/ati-agp.c @@ -124,18 +124,18 @@ static int ati_create_gatt_pages(int nr_tables) for (i = 0; i < nr_tables; i++) { entry = kzalloc(sizeof(struct ati_page_map), GFP_KERNEL); if (entry == NULL) { - while (i>0) { - kfree (tables[i-1]); + while (i > 0) { + kfree(tables[i-1]); i--; } - kfree (tables); - tables = NULL; + kfree(tables); retval = -ENOMEM; break; } tables[i] = entry; retval = ati_create_page_map(entry); - if (retval != 0) break; + if (retval != 0) + break; } ati_generic_private.num_tables = nr_tables; ati_generic_private.gatt_pages = tables;