From: Huang Rui Date: Mon, 23 Sep 2013 16:03:43 +0000 (+0800) Subject: usb: usbtest: bmAttributes would better be masked X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=77a3a0aa39da49499c4029ee8c4227dac362a076;p=linux-beck.git usb: usbtest: bmAttributes would better be masked When transfer type is isochronous, the other bits (bits 5..2) of bmAttributes in endpoint descriptor might not be set zero. So it's better to use usb_endpoint_type routine to mask bmAttributes with USB_ENDPOINT_XFERTYPE_MASK to judge the transfter type later. Acked-by: Alan Stern Signed-off-by: Huang Rui Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/misc/usbtest.c b/drivers/usb/misc/usbtest.c index aa28ac8c7607..3e91d3e98ee8 100644 --- a/drivers/usb/misc/usbtest.c +++ b/drivers/usb/misc/usbtest.c @@ -120,7 +120,7 @@ get_endpoints(struct usbtest_dev *dev, struct usb_interface *intf) struct usb_host_endpoint *e; e = alt->endpoint + ep; - switch (e->desc.bmAttributes) { + switch (usb_endpoint_type(&e->desc)) { case USB_ENDPOINT_XFER_BULK: break; case USB_ENDPOINT_XFER_ISOC: