From: Joerg Roedel Date: Mon, 8 Mar 2010 13:20:07 +0000 (+0100) Subject: x86/amd-iommu: Use helper function to destroy domain X-Git-Tag: v2.6.33.3~66 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=78b124998ce07bb27cf23bd6d1a7337ba22cb262;p=karo-tx-linux.git x86/amd-iommu: Use helper function to destroy domain commit 8b408fe4f853dcfa18d133aa4cf1d7546b4c3870 upstream. In the amd_iommu_domain_destroy the protection_domain_free function is partly reimplemented. The 'partly' is the bug here because the domain is not deleted from the domain list. This results in use-after-free errors and data-corruption. Fix it by just using protection_domain_free instead. Signed-off-by: Joerg Roedel Signed-off-by: Greg Kroah-Hartman --- diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c index 0e9ab4af619b..2e775169bdf0 100644 --- a/arch/x86/kernel/amd_iommu.c +++ b/arch/x86/kernel/amd_iommu.c @@ -2379,9 +2379,7 @@ static void amd_iommu_domain_destroy(struct iommu_domain *dom) free_pagetable(domain); - domain_id_free(domain->id); - - kfree(domain); + protection_domain_free(domain); dom->priv = NULL; }