From: Liu Ying <Ying.Liu@freescale.com>
Date: Tue, 29 Oct 2013 04:31:36 +0000 (+0800)
Subject: ENGR00285273-3 IPU dev:Remove unnecessary memset before kfree
X-Git-Tag: KARO-TX6-2014-08-21~1^2~189
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=78d388ed8738653c40d027a4d50820a83421b285;p=karo-tx-linux.git

ENGR00285273-3 IPU dev:Remove unnecessary memset before kfree

This patch removes unnecessary memset() before kfree().
Also, it fixes a potential NULL pointer dereference(writing
to a freed block of memory).

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---

diff --git a/drivers/mxc/ipu3/ipu_device.c b/drivers/mxc/ipu3/ipu_device.c
index e20241476424..72a9905d5bea 100644
--- a/drivers/mxc/ipu3/ipu_device.c
+++ b/drivers/mxc/ipu3/ipu_device.c
@@ -1414,8 +1414,6 @@ static void task_mem_free(struct kref *ref)
 {
 	struct ipu_task_entry *tsk =
 			container_of(ref, struct ipu_task_entry, refcount);
-
-	memset(tsk, 0, sizeof(*tsk));
 	kfree(tsk);
 }
 
@@ -1731,7 +1729,6 @@ err_exit:
 		if (!tsk)
 			continue;
 		kfree(tsk);
-		memset(tsk, 0, sizeof(*tsk));
 	}
 	t->state = STATE_ERR;
 	return ret;