From: Alexey Khoroshilov Date: Fri, 29 Apr 2016 22:11:12 +0000 (+0300) Subject: ide-tape: fix misprint in failure handling in idetape_init() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=79f18a0637033f588accaa05621225c60301514a;p=linux-beck.git ide-tape: fix misprint in failure handling in idetape_init() If driver_register() failed there is no sense to call driver_unregister(). unregister_chrdev() should be called here. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov Signed-off-by: David S. Miller --- diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c index 12fa04997dcc..9ecf4e35adcd 100644 --- a/drivers/ide/ide-tape.c +++ b/drivers/ide/ide-tape.c @@ -2052,12 +2052,12 @@ static int __init idetape_init(void) error = driver_register(&idetape_driver.gen_driver); if (error) - goto out_free_driver; + goto out_free_chrdev; return 0; -out_free_driver: - driver_unregister(&idetape_driver.gen_driver); +out_free_chrdev: + unregister_chrdev(IDETAPE_MAJOR, "ht"); out_free_class: class_destroy(idetape_sysfs_class); out: