From: Alan Stern Date: Wed, 15 Jan 2014 20:37:04 +0000 (-0500) Subject: [SCSI] sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE X-Git-Tag: v3.15-rc1~136^2~43 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7aae51347b21eb738dc1981df1365b57a6c5ee4e;p=karo-tx-linux.git [SCSI] sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE Evidently some wacky USB-ATA bridges don't recognize the SYNCHRONIZE CACHE command, as shown in this email thread: http://marc.info/?t=138978356200002&r=1&w=2 The fact that we can't tell them to drain their caches shouldn't prevent the system from going into suspend. Therefore sd_sync_cache() shouldn't return an error if the device replies with an Invalid Command ASC. Signed-off-by: Alan Stern Reported-by: Sven Neumann Tested-by: Daniel Mack CC: Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 470954aba728..36d1a23f14be 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1463,8 +1463,8 @@ static int sd_sync_cache(struct scsi_disk *sdkp) sd_print_sense_hdr(sdkp, &sshdr); /* we need to evaluate the error return */ if (scsi_sense_valid(&sshdr) && - /* 0x3a is medium not present */ - sshdr.asc == 0x3a) + (sshdr.asc == 0x3a || /* medium not present */ + sshdr.asc == 0x20)) /* invalid command */ /* this is no error here */ return 0;