From: Andy Grover <andy.grover@oracle.com>
Date: Thu, 9 Apr 2009 14:09:40 +0000 (+0000)
Subject: RDS: Fix ordering in a conditional
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7acd4a794c1530af063e51f3f7171e75556458f3;p=linux-beck.git

RDS: Fix ordering in a conditional

Putting the constant first is a supposed "best practice" that actually makes
the code harder to read.

Thanks to Roland Dreier for finding a bug in this "simple, obviously correct"
patch.

Signed-off-by: Andy Grover <andy.grover@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/rds/rdma.c b/net/rds/rdma.c
index eaeeb91e1119..e390dc70b9d9 100644
--- a/net/rds/rdma.c
+++ b/net/rds/rdma.c
@@ -155,7 +155,7 @@ static int rds_pin_pages(unsigned long user_addr, unsigned int nr_pages,
 			     nr_pages, write, 0, pages, NULL);
 	up_read(&current->mm->mmap_sem);
 
-	if (0 <= ret && (unsigned) ret < nr_pages) {
+	if (ret >= 0 && ret < nr_pages) {
 		while (ret--)
 			put_page(pages[ret]);
 		ret = -EFAULT;