From: Devendra Naga Date: Wed, 15 Aug 2012 09:11:03 +0000 (+0545) Subject: staging: serqt_usb2: remove retval initialisation in qt_tiocmget and qt_tiocmset X-Git-Tag: next-20120816~16^2~1 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7b11eb3eaaf049586bc44e2512c5d0cd64eb79df;p=karo-tx-linux.git staging: serqt_usb2: remove retval initialisation in qt_tiocmget and qt_tiocmset in qt_tiocmset, the retval gets assigned if we have a valid serial pointer in the critical section (between mutex_lock and _unlock) of the code, no need to initialise this variable. the same retval assignment follows in the qt_tiocmget function also, so remove the initialisation here too. Signed-off-by: Devendra Naga Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c index 135eb3896b39..5a5ea482a216 100644 --- a/drivers/staging/serqt_usb2/serqt_usb2.c +++ b/drivers/staging/serqt_usb2/serqt_usb2.c @@ -1412,7 +1412,7 @@ static int qt_tiocmget(struct tty_struct *tty) struct usb_serial_port *port = tty->driver_data; struct usb_serial *serial = get_usb_serial(port, __func__); struct quatech_port *qt_port = qt_get_port_private(port); - int retval = -ENODEV; + int retval; if (!serial) return -ENODEV; @@ -1430,7 +1430,7 @@ static int qt_tiocmset(struct tty_struct *tty, struct usb_serial_port *port = tty->driver_data; struct usb_serial *serial = get_usb_serial(port, __func__); struct quatech_port *qt_port = qt_get_port_private(port); - int retval = -ENODEV; + int retval; if (!serial) return -ENODEV;