From: Güngör Erseymen <gelurine@gmail.com>
Date: Fri, 7 Jun 2013 18:29:50 +0000 (+0300)
Subject: staging: comedi: remove 'bi.subdevice < 0' check in do_bufinfo_ioctl()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7b1a5e2f4f5afde4f1dadf58223c2f293208293b;p=linux-beck.git

staging: comedi: remove 'bi.subdevice < 0' check in do_bufinfo_ioctl()

Type of variable 'bi' is struct comedi_bufinfo and 'subdevice' is
defined as unsigned, so there is no need to check if it is less then
zero.

Signed-off-by: Güngör Erseymen <gelurine@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 986f19572689..c561a0eda92a 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -913,7 +913,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev,
 	if (copy_from_user(&bi, arg, sizeof(bi)))
 		return -EFAULT;
 
-	if (bi.subdevice >= dev->n_subdevices || bi.subdevice < 0)
+	if (bi.subdevice >= dev->n_subdevices)
 		return -EINVAL;
 
 	s = &dev->subdevices[bi.subdevice];