From: Bill Pemberton Date: Thu, 20 Sep 2012 20:55:28 +0000 (-0400) Subject: staging: dgrp: add dgrp to the build X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7b6d45c211a401a9bdeebfa96f8a4c811bd3eeaf;p=linux-beck.git staging: dgrp: add dgrp to the build Kconfig and Makefile changes to add dgrp to the build system. Signed-off-by: Bill Pemberton Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig index e3402d5644dd..21114512fcb2 100644 --- a/drivers/staging/Kconfig +++ b/drivers/staging/Kconfig @@ -136,4 +136,6 @@ source "drivers/staging/csr/Kconfig" source "drivers/staging/omap-thermal/Kconfig" +source "drivers/staging/dgrp/Kconfig" + endif # STAGING diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index 3be59d02cae4..17c43c4cacaa 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -60,3 +60,4 @@ obj-$(CONFIG_USB_G_CCG) += ccg/ obj-$(CONFIG_WIMAX_GDM72XX) += gdm72xx/ obj-$(CONFIG_CSR_WIFI) += csr/ obj-$(CONFIG_OMAP_BANDGAP) += omap-thermal/ +obj-$(CONFIG_DGRP) += dgrp/ diff --git a/drivers/staging/dgrp/TODO b/drivers/staging/dgrp/TODO index 63341ade90d4..3ef2611bc6d7 100644 --- a/drivers/staging/dgrp/TODO +++ b/drivers/staging/dgrp/TODO @@ -1,7 +1,13 @@ - Use configfs for config stuff. This will require changes to the user space code. -- Check the calls to tty_register_device. In particular, check to see - if there should be some handling for IS_ERR(classp). - - dgrp_send() and dgrp_receive() could use some refactoring + +- Don't automatically create CHAN_MAX (64) channel array entries for + every device as many devices are going to have much less than 64 + channels. + +- The locking needs to be checked. It seems haphazardly done in most + places. + +- Check Kconfig dependencies