From: Wei Yongjun Date: Mon, 13 Jun 2016 14:39:57 +0000 (+0000) Subject: ASoC: sti: fix return value check in uni_player_parse_dt_audio_glue() X-Git-Tag: v4.8-rc1~84^2~1^2~2^4 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7d267ddfd560da3232f4deed3427839dd0126a4a;p=karo-tx-linux.git ASoC: sti: fix return value check in uni_player_parse_dt_audio_glue() In case of error, the function syscon_regmap_lookup_by_phandle() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun Signed-off-by: Mark Brown --- diff --git a/sound/soc/sti/uniperif_player.c b/sound/soc/sti/uniperif_player.c index ee1c7c245bc7..1ac2db205a0d 100644 --- a/sound/soc/sti/uniperif_player.c +++ b/sound/soc/sti/uniperif_player.c @@ -1029,9 +1029,9 @@ static int uni_player_parse_dt_audio_glue(struct platform_device *pdev, regmap = syscon_regmap_lookup_by_phandle(node, "st,syscfg"); - if (!regmap) { + if (IS_ERR(regmap)) { dev_err(&pdev->dev, "sti-audio-clk-glue syscf not found\n"); - return -EINVAL; + return PTR_ERR(regmap); } player->clk_sel = regmap_field_alloc(regmap, regfield[0]);