From: Dan Carpenter Date: Fri, 19 Sep 2014 10:56:56 +0000 (+0300) Subject: UBI: return on error in rename_volumes() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=7fbbd05799976c0611dcb229649260504b2bdef5;p=linux-beck.git UBI: return on error in rename_volumes() I noticed this during a code review. We are checking that the strlen() of ->name is not less than the ->name_len which the user gave us. I believe this bug is harmless but clearly we meant to return here instead of setting an error code and then not using it. Signed-off-by: Dan Carpenter Signed-off-by: Artem Bityutskiy --- diff --git a/drivers/mtd/ubi/cdev.c b/drivers/mtd/ubi/cdev.c index 20aeb277d8d4..59de69a24e40 100644 --- a/drivers/mtd/ubi/cdev.c +++ b/drivers/mtd/ubi/cdev.c @@ -701,7 +701,7 @@ static int rename_volumes(struct ubi_device *ubi, req->ents[i].name[req->ents[i].name_len] = '\0'; n = strlen(req->ents[i].name); if (n != req->ents[i].name_len) - err = -EINVAL; + return -EINVAL; } /* Make sure volume IDs and names are unique */