From: Dan Carpenter Date: Mon, 5 Nov 2012 06:42:17 +0000 (+0300) Subject: xen/privcmd: fix condition in privcmd_close() X-Git-Tag: next-20121205~35^2^2~1 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=80840912da1d6cdab5e2e8cce1fb743f84c1613e;p=karo-tx-linux.git xen/privcmd: fix condition in privcmd_close() The parenthesis are in the wrong place so the original code is equivalent to: if (!xen_feature(XENFEAT_writable_descriptor_tables)) { ... Which obviously was not intended. Signed-off-by: Dan Carpenter Signed-off-by: Konrad Rzeszutek Wilk --- diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index b9d08987a5a5..6011f3bde537 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -495,7 +495,7 @@ static void privcmd_close(struct vm_area_struct *vma) struct page **pages = vma->vm_private_data; int numpgs = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT; - if (!xen_feature(XENFEAT_auto_translated_physmap || !numpgs || !pages)) + if (!xen_feature(XENFEAT_auto_translated_physmap) || !numpgs || !pages) return; xen_unmap_domain_mfn_range(vma, numpgs, pages);