From: H Hartley Sweeten Date: Tue, 23 Apr 2013 01:34:19 +0000 (-0700) Subject: staging: comedi: das800: remove 'volatile' on private data variables X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=808cea5a5d538d787f42e2ec48527bfb7e830490;p=linux-beck.git staging: comedi: das800: remove 'volatile' on private data variables As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Also, cleanup the comments to avoid > 80 char lines. Signed-off-by: H Hartley Sweeten Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c index e2bd371114be..4c28b383869d 100644 --- a/drivers/staging/comedi/drivers/das800.c +++ b/drivers/staging/comedi/drivers/das800.c @@ -225,11 +225,11 @@ static const struct das800_board das800_boards[] = { }; struct das800_private { - volatile unsigned int count; /* number of data points left to be taken */ - volatile int forever; /* flag indicating whether we should take data forever */ - unsigned int divisor1; /* value to load into board's counter 1 for timed conversions */ - unsigned int divisor2; /* value to load into board's counter 2 for timed conversions */ - volatile int do_bits; /* digital output bits */ + unsigned int count; /* number of data points left to be taken */ + int forever; /* flag that we should take data forever */ + unsigned int divisor1; /* counter 1 value for timed conversions */ + unsigned int divisor2; /* counter 2 value for timed conversions */ + int do_bits; /* digital output bits */ }; static void das800_ind_write(struct comedi_device *dev,