From: Larry Finger Date: Wed, 16 Aug 2006 16:05:16 +0000 (-0500) Subject: [PATCH] bcm43xx: optimization of DMA bitfields X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=80b60fa8488e98ceaecb8f976abe79df50988037;p=linux-beck.git [PATCH] bcm43xx: optimization of DMA bitfields Convert the bitfields in the bcm43xx DMA code to properly aligned u8 booleans. These flags are accessed in the DMA hotpath, so it's a good idea to waste a few bytes of memory for the sake of speed by not requiring masking (and probably shifting) of the bitfields. Signed-off-by: Michael Buesch Signed-Off-By: Larry Finger Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_dma.h b/drivers/net/wireless/bcm43xx/bcm43xx_dma.h index 258a2f9bd7a6..e04bcaddd1d0 100644 --- a/drivers/net/wireless/bcm43xx/bcm43xx_dma.h +++ b/drivers/net/wireless/bcm43xx/bcm43xx_dma.h @@ -235,9 +235,12 @@ struct bcm43xx_dmaring { u16 mmio_base; /* DMA controller index number (0-5). */ int index; - u8 tx:1, /* TRUE, if this is a TX ring. */ - dma64:1, /* TRUE, if 64-bit DMA is enabled (FALSE if 32bit). */ - suspended:1; /* TRUE, if transfers are suspended on this ring. */ + /* Boolean. Is this a TX ring? */ + u8 tx; + /* Boolean. 64bit DMA if true, 32bit DMA otherwise. */ + u8 dma64; + /* Boolean. Are transfers suspended on this ring? */ + u8 suspended; struct bcm43xx_private *bcm; #ifdef CONFIG_BCM43XX_DEBUG /* Maximum number of used slots. */