From: Yan, Zheng <zyan@redhat.com>
Date: Tue, 13 Dec 2016 08:03:26 +0000 (+0800)
Subject: ceph: avoid creating orphan object when checking pool permission
X-Git-Tag: v4.10-rc1~66^2~2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=80e80fbb584dc0d0dc894c4965bc2a199c7cd3f2;p=karo-tx-linux.git

ceph: avoid creating orphan object when checking pool permission

Pool permission check needs to write to the first object. But for
snapshot, head of the first object may have already been deleted.
Skip the check for snapshot inode to avoid creating orphan object.

Link: http://tracker.ceph.com/issues/18211
Signed-off-by: Yan, Zheng <zyan@redhat.com>
---

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 7d69f25d0c90..a0f1e2b91c8e 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1948,6 +1948,15 @@ int ceph_pool_perm_check(struct ceph_inode_info *ci, int need)
 	struct ceph_string *pool_ns;
 	int ret, flags;
 
+	if (ci->i_vino.snap != CEPH_NOSNAP) {
+		/*
+		 * Pool permission check needs to write to the first object.
+		 * But for snapshot, head of the first object may have alread
+		 * been deleted. Skip check to avoid creating orphan object.
+		 */
+		return 0;
+	}
+
 	if (ceph_test_mount_opt(ceph_inode_to_client(&ci->vfs_inode),
 				NOPOOLPERM))
 		return 0;