From: Krzysztof Kozlowski Date: Thu, 16 Oct 2014 08:23:28 +0000 (+0200) Subject: regulator: s2mps11: Don't zero allocated memory for external control X-Git-Tag: v3.19-rc1~178^2~1^6 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=80e82ac2ddf0e3de6f38de863b6d90de38961ed8;p=karo-tx-linux.git regulator: s2mps11: Don't zero allocated memory for external control The driver was allocating memory for storing GPIOs for external control with unnecessary GFP_ZERO flag. Then right after allocation it initialized memory to -EINVAL in loop. Skip the GFP_ZERO flag. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index adab82d5279f..7f59e67252e7 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -845,7 +845,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev) return -EINVAL; }; - s2mps11->ext_control_gpio = devm_kzalloc(&pdev->dev, + s2mps11->ext_control_gpio = devm_kmalloc(&pdev->dev, sizeof(*s2mps11->ext_control_gpio) * s2mps11->rdev_num, GFP_KERNEL); if (!s2mps11->ext_control_gpio)