From: YAMANE Toshiaki Date: Thu, 20 Sep 2012 11:58:20 +0000 (+0900) Subject: staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c X-Git-Tag: next-20120924~26^2~40 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=814394100d5bfd5b33cddede907a4e0a216b93b6;p=karo-tx-linux.git staging/rts_pstor: Delete some lines (dev_info() and dev_err()) in rtsx.c fixed some coccinelle warnings. + drivers/staging/rts_pstor/rtsx.c:397:16-19: ERROR: dev is NULL but dereferenced. drivers/staging/rts_pstor/rtsx.c:447:16-19: ERROR: dev is NULL but dereferenced. drivers/staging/rts_pstor/rtsx.c:358:16-19: ERROR: dev is NULL but dereferenced. Signed-off-by: YAMANE Toshiaki Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rts_pstor/rtsx.c b/drivers/staging/rts_pstor/rtsx.c index 213829ec7df9..afe9c2e763d7 100644 --- a/drivers/staging/rts_pstor/rtsx.c +++ b/drivers/staging/rts_pstor/rtsx.c @@ -352,12 +352,8 @@ static int rtsx_suspend(struct pci_dev *pci, pm_message_t state) struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci); struct rtsx_chip *chip; - dev_info(&dev->pci->dev, "Ready to suspend\n"); - - if (!dev) { - dev_err(&dev->pci->dev, "Invalid memory\n"); + if (!dev) return 0; - } /* lock the device pointers */ mutex_lock(&(dev->dev_mutex)); @@ -391,12 +387,8 @@ static int rtsx_resume(struct pci_dev *pci) struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci); struct rtsx_chip *chip; - dev_info(&dev->pci->dev, "Ready to resume\n"); - - if (!dev) { - dev_err(&dev->pci->dev, "Invalid memory\n"); + if (!dev) return 0; - } chip = dev->chip; @@ -441,12 +433,8 @@ static void rtsx_shutdown(struct pci_dev *pci) struct rtsx_dev *dev = (struct rtsx_dev *)pci_get_drvdata(pci); struct rtsx_chip *chip; - dev_info(&dev->pci->dev, "Ready to shutdown\n"); - - if (!dev) { - dev_err(&dev->pci->dev, "Invalid memory\n"); + if (!dev) return; - } chip = dev->chip;