From: Alex Elder <elder@linaro.org>
Date: Mon, 8 Jun 2015 17:05:12 +0000 (-0500)
Subject: greybus: uart: properly interpret receive data size
X-Git-Tag: v4.9-rc1~119^2~378^2~21^2~1491
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=81c3a77207450cb4187e8af700797e7d3209a568;p=karo-tx-linux.git

greybus: uart: properly interpret receive data size

In gb_uart_request_recv(), the receive data size is in little-endian
format.  Do the proper byte swapping of that value before using it.
Found by "make check".

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
---

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 37bb2e2ddf59..6db49930cf40 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -78,6 +78,7 @@ static int gb_uart_request_recv(u8 type, struct gb_operation *op)
 	struct gb_uart_recv_data_request *receive_data;
 	struct gb_uart_serial_state_request *serial_state;
 	struct tty_port *port = &gb_tty->port;
+	u16 recv_data_size;
 	int count;
 	int ret = 0;
 
@@ -85,15 +86,16 @@ static int gb_uart_request_recv(u8 type, struct gb_operation *op)
 	case GB_UART_TYPE_RECEIVE_DATA:
 		receive_data = request->payload;
 		count = gb_tty->buffer_payload_max - sizeof(*receive_data);
-		if (!receive_data->size || receive_data->size > count)
+		recv_data_size = le16_to_cpu(receive_data->size);
+		if (!recv_data_size || recv_data_size > count)
 			return -EINVAL;
 
 		count = tty_insert_flip_string(port, receive_data->data,
-					       receive_data->size);
-		if (count != receive_data->size) {
+					       recv_data_size);
+		if (count != recv_data_size) {
 			dev_err(&connection->dev,
 				"UART: RX 0x%08x bytes only wrote 0x%08x\n",
-				receive_data->size, count);
+				recv_data_size, count);
 		}
 		if (count)
 			tty_flip_buffer_push(port);