From: Linus Walleij Date: Tue, 22 Dec 2015 14:35:47 +0000 (+0100) Subject: ARM: scoop: Be sure to clamp return value X-Git-Tag: v4.5-rc1~47^2~2 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=86d5e657d27851beb0e3e7bf48f13263acc5196a;p=karo-tx-linux.git ARM: scoop: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: arm@kernel.org Cc: Richard Purdie Signed-off-by: Linus Walleij Signed-off-by: Olof Johansson --- diff --git a/arch/arm/common/scoop.c b/arch/arm/common/scoop.c index 45f4c21e393c..e0df333202b8 100644 --- a/arch/arm/common/scoop.c +++ b/arch/arm/common/scoop.c @@ -84,7 +84,7 @@ static int scoop_gpio_get(struct gpio_chip *chip, unsigned offset) struct scoop_dev *sdev = container_of(chip, struct scoop_dev, gpio); /* XXX: I'm unsure, but it seems so */ - return ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1)); + return !!(ioread16(sdev->base + SCOOP_GPRR) & (1 << (offset + 1))); } static int scoop_gpio_direction_input(struct gpio_chip *chip,