From: Alban Bedel <albeu@free.fr>
Date: Sat, 25 Feb 2012 15:15:57 +0000 (+0100)
Subject: ALSA: azt3328 - Fix NULL ptr dereference on cards without OPL3
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=87c9e7d7027643bf248b396c15c804456e967fcd;p=linux-beck.git

ALSA: azt3328 - Fix NULL ptr dereference on cards without OPL3

opl3->private_data was set even if opl3 could not be created.

Signed-off-by: Alban Bedel <albeu@free.fr>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/azt3328.c b/sound/pci/azt3328.c
index 95ffa6a9db6e..496f14c1a731 100644
--- a/sound/pci/azt3328.c
+++ b/sound/pci/azt3328.c
@@ -2684,10 +2684,9 @@ snd_azf3328_probe(struct pci_dev *pci, const struct pci_device_id *pci_id)
 		err = snd_opl3_hwdep_new(opl3, 0, 1, NULL);
 		if (err < 0)
 			goto out_err;
+		opl3->private_data = chip;
 	}
 
-	opl3->private_data = chip;
-
 	sprintf(card->longname, "%s at 0x%lx, irq %i",
 		card->shortname, chip->ctrl_io, chip->irq);