From: Dan Carpenter Date: Wed, 11 Jun 2014 06:04:33 +0000 (+0300) Subject: char: xilinx_hwicap: missing error code if ioremap() fails X-Git-Tag: v3.17-rc1~125^2~42 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8a26af30ff55bec82443e718e26efd6b3a8bba83;p=karo-tx-linux.git char: xilinx_hwicap: missing error code if ioremap() fails Return -ENOMEM instead of success if ioremap() fails. Signed-off-by: Dan Carpenter Reviewed-by: Jingoo Han Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c index f6345f932e46..9b1a5ac4881d 100644 --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c @@ -661,6 +661,7 @@ static int hwicap_setup(struct device *dev, int id, drvdata->base_address = ioremap(drvdata->mem_start, drvdata->mem_size); if (!drvdata->base_address) { dev_err(dev, "ioremap() failed\n"); + retval = -ENOMEM; goto failed2; }