From: John Crispin Date: Fri, 9 Aug 2013 18:54:31 +0000 (+0200) Subject: serial: MIPS: lantiq: fix clock error check X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8ad2ee955b810e2a8061d2d3d2e4e4072250b5ec;p=linux-beck.git serial: MIPS: lantiq: fix clock error check The clock should be checked with the proper IS_ERR() api before using it. Signed-off-by: John Crispin Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 93ac04686eb9..88d01e0bb0c8 100644 --- a/drivers/tty/serial/lantiq.c +++ b/drivers/tty/serial/lantiq.c @@ -318,7 +318,7 @@ lqasc_startup(struct uart_port *port) struct ltq_uart_port *ltq_port = to_ltq_uart_port(port); int retval; - if (ltq_port->clk) + if (!IS_ERR(ltq_port->clk)) clk_enable(ltq_port->clk); port->uartclk = clk_get_rate(ltq_port->fpiclk); @@ -386,7 +386,7 @@ lqasc_shutdown(struct uart_port *port) port->membase + LTQ_ASC_RXFCON); ltq_w32_mask(ASCTXFCON_TXFEN, ASCTXFCON_TXFFLU, port->membase + LTQ_ASC_TXFCON); - if (ltq_port->clk) + if (!IS_ERR(ltq_port->clk)) clk_disable(ltq_port->clk); }