From: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Date: Thu, 26 Jun 2014 11:32:49 +0000 (+0200)
Subject: pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero
X-Git-Tag: v3.17-rc1~85^2~27
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8b0c107ce049ddaf0ca9d8cd4faac1cf5c1e9f20;p=karo-tx-linux.git

pinctrl: pinctrl-st.c: Cleaning up if unsigned is less than zero

Remove checking if a unsigned is less than zero

This was found using a static code analysis program called cppcheck.

Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 506561131d7f..1845870413ea 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -1250,7 +1250,7 @@ static int st_pctl_parse_functions(struct device_node *np,
 	func = &info->functions[index];
 	func->name = np->name;
 	func->ngroups = of_get_child_count(np);
-	if (func->ngroups <= 0) {
+	if (func->ngroups == 0) {
 		dev_err(info->dev, "No groups defined\n");
 		return -EINVAL;
 	}