From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Apr 2015 23:43:54 +0000 (+1000)
Subject: ocfs2: dereferencing freed pointers in ocfs2_reflink()
X-Git-Tag: KARO-TXA5-2015-06-26~18^2~481
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8b1e36cf74855e5a85b292411d0e4aa80b0deee0;p=karo-tx-linux.git

ocfs2: dereferencing freed pointers in ocfs2_reflink()

The code at the "out" label assumes that "default_acl" and "acl" are NULL,
but actually the pointers can be NULL, unitialized, or freed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Mark Fasheh <mfasheh@suse.de>
Cc: Joel Becker <jlbec@evilplan.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
index ee541f92dab4..df3a500789c7 100644
--- a/fs/ocfs2/refcounttree.c
+++ b/fs/ocfs2/refcounttree.c
@@ -4276,7 +4276,7 @@ static int ocfs2_reflink(struct dentry *old_dentry, struct inode *dir,
 	error = posix_acl_create(dir, &mode, &default_acl, &acl);
 	if (error) {
 		mlog_errno(error);
-		goto out;
+		return error;
 	}
 
 	error = ocfs2_create_inode_in_orphan(dir, mode,