From: Jes Sorensen Date: Sun, 25 May 2014 20:43:10 +0000 (+0200) Subject: staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface() X-Git-Tag: next-20140530~19^2~226 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8b506ef18102fd1a30719d075e2be0efa1c2a920;p=karo-tx-linux.git staging: rtl8723au: Do not call netdev_open23a() from cfg80211_rtw_change_iface() Calling open on the device when changing the interface type is wrong. Let the stack call open at the right time. Signed-off-by: Jes Sorensen Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c index f75a82596243..2bcdbe10ae0f 100644 --- a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c @@ -1391,15 +1391,6 @@ static int cfg80211_rtw_change_iface(struct wiphy *wiphy, int ret = 0; DBG_8723A("%s(%s): call netdev_open23a\n", __func__, ndev->name); - if (netdev_open23a(ndev) != 0) { - ret = -EPERM; - goto exit; - } - - if (_FAIL == rtw_pwr_wakeup(padapter)) { - ret = -EPERM; - goto exit; - } old_type = rtw_wdev->iftype; DBG_8723A("%s(%s): old_iftype =%d, new_iftype =%d\n",