From: Lars-Peter Clausen <lars@metafoo.de>
Date: Tue, 23 Sep 2014 02:15:48 +0000 (+0200)
Subject: ASoC: Fix snd_soc_{new,free}_ac97_codec() locking removal
X-Git-Tag: v3.18-rc1~99^2~8^2~11^2~2
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8c8f2f6fc1c8eec9e14810f21386fe295a42a40f;p=karo-tx-linux.git

ASoC: Fix snd_soc_{new,free}_ac97_codec() locking removal

Commit e3f205a72c45 ("ASoC: Remove locking in
snd_soc_{new,free}_ac97_codec()") overlooked a unlock on one of the error
paths.

Fixes: e3f205a72c45 ("ASoC: Remove locking in snd_soc_{new,free}_ac97_codec()")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index a504cf42bf0a..3c57f5cf2779 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -2115,7 +2115,6 @@ int snd_soc_new_ac97_codec(struct snd_soc_codec *codec,
 	if (codec->ac97->bus == NULL) {
 		kfree(codec->ac97);
 		codec->ac97 = NULL;
-		mutex_unlock(&codec->mutex);
 		return -ENOMEM;
 	}