From: Felipe Balbi <balbi@ti.com>
Date: Wed, 20 Feb 2013 08:31:42 +0000 (+0200)
Subject: base: core: WARN() about bogus permissions on device attributes
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8f46baaa7ec6cd0851794020b31958e64679dd26;p=linux-beck.git

base: core: WARN() about bogus permissions on device attributes

Whenever a struct device_attribute is registered
with mismatched permissions - read permission without
a show routine or write permission without store
routine - we will issue a big warning so we catch
those early enough.

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 56536f4b0f6b..a7391a30cb29 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -563,8 +563,15 @@ int device_create_file(struct device *dev,
 		       const struct device_attribute *attr)
 {
 	int error = 0;
-	if (dev)
+
+	if (dev) {
+		WARN(((attr->attr.mode & S_IWUGO) && !attr->store),
+				"Write permission without 'store'\n");
+		WARN(((attr->attr.mode & S_IRUGO) && !attr->show),
+				"Read permission without 'show'\n");
 		error = sysfs_create_file(&dev->kobj, &attr->attr);
+	}
+
 	return error;
 }