From: Thomas Gleixner <tglx@linutronix.de>
Date: Mon, 21 Feb 2011 13:19:42 +0000 (+0100)
Subject: genirq: Add missing break in __irq_set_trigger()
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=8fff39e06987492da3d4a0b9ec7cdbd245b6762b;p=linux-beck.git

genirq: Add missing break in __irq_set_trigger()

The switch case in __irq_set_trigger() lacks a break, which emits a
pr_err unconditionally on success.

Reported-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 6cca1956c503..01f8a9519e63 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -567,6 +567,7 @@ int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
 		if (chip != desc->irq_data.chip)
 			irq_chip_set_defaults(desc->irq_data.chip);
 		ret = 0;
+		break;
 	default:
 		pr_err("setting trigger mode %lu for irq %u failed (%pF)\n",
 		       flags, irq, chip->irq_set_type);