From: NeilBrown Date: Mon, 31 Oct 2011 01:59:44 +0000 (+1100) Subject: md/raid10: Fix bug when activating a hot-spare. X-Git-Tag: v3.1.1~120 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=908accb6a475037a826cc151609c575415aa7e89;p=karo-tx-linux.git md/raid10: Fix bug when activating a hot-spare. commit 7fcc7c8acf0fba44d19a713207af7e58267c1179 upstream. This is a fairly serious bug in RAID10. When a RAID10 array is degraded and a hot-spare is activated, the spare does not take up the empty slot, but rather replaces the first working device. This is likely to make the array non-functional. It would normally be possible to recover the data, but that would need care and is not guaranteed. This bug was introduced in commit 2bb77736ae5dca0a189829fbb7379d43364a9dac which first appeared in 3.1. Signed-off-by: NeilBrown Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 0cd9672cf9cb..1d44228530ab 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c @@ -1337,7 +1337,7 @@ static int raid10_add_disk(mddev_t *mddev, mdk_rdev_t *rdev) mirror_info_t *p = &conf->mirrors[mirror]; if (p->recovery_disabled == mddev->recovery_disabled) continue; - if (!p->rdev) + if (p->rdev) continue; disk_stack_limits(mddev->gendisk, rdev->bdev,