From: Santhosh Pai <santhosh.pai88@yahoo.com>
Date: Mon, 29 Jun 2015 09:44:03 +0000 (+0100)
Subject: staging: Comedi: comedi_fops: Fixed the return error code
X-Git-Tag: v4.3-rc1~158^2~691
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=90e6f51da718fc982eafd3dd7d6c78b378f67136;p=karo-tx-linux.git

staging: Comedi: comedi_fops: Fixed the return error code

This patch fixes the checkpatch.pl warning:

WARNING: ENOSYS means 'invalid syscall nr' and nothing else

try_module_get fails when the reference count of the module is not
allowed to be incremented ,and hence -ENXIO is returned indicating
no device or address.

[IA - combined two of santhosh's changes to the error return value!]

Signed-off-by: santhosh pai <santhosh.pai88@yahoo.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
index 1679bfba25a9..4820ab6d0aa8 100644
--- a/drivers/staging/comedi/comedi_fops.c
+++ b/drivers/staging/comedi/comedi_fops.c
@@ -2606,7 +2606,7 @@ static int comedi_open(struct inode *inode, struct file *file)
 	}
 	if (dev->attached && dev->use_count == 0) {
 		if (!try_module_get(dev->driver->module)) {
-			rc = -ENOSYS;
+			rc = -ENXIO;
 			goto out;
 		}
 		if (dev->open) {