From: Alan Cox Date: Thu, 25 Oct 2012 01:15:08 +0000 (+1100) Subject: binfmt_elf: fix corner case kfree of uninitialized data X-Git-Tag: next-20121025~1^2~52 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=91cbcc0e489c9f53c9f66c759c484343c2386e2c;p=karo-tx-linux.git binfmt_elf: fix corner case kfree of uninitialized data If elf_core_dump() is called and fill_note_info() fails in the kmalloc() then it returns 0 but has not yet initialised all the needed fields. As a result we do a kfree(randomness) after correctly skipping the thread data. Signed-off-by: Alan Cox Signed-off-by: Andrew Morton --- diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index fbd9f60bd763..5c0721863897 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -1600,8 +1600,10 @@ static int fill_note_info(struct elfhdr *elf, int phdrs, info->thread = NULL; psinfo = kmalloc(sizeof(*psinfo), GFP_KERNEL); - if (psinfo == NULL) + if (psinfo == NULL) { + info->psinfo.data = NULL; /* So we don't free this wrongly */ return 0; + } fill_note(&info->psinfo, "CORE", NT_PRPSINFO, sizeof(*psinfo), psinfo);