From: Maxime Ripard Date: Wed, 30 Jul 2014 08:30:21 +0000 (+0200) Subject: dmaengine: sun6i: Remove switch statement from buswidth convertion routine X-Git-Tag: v3.17-rc1~45^2~18 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=92e4a3bf3812b0b0d06c6736fe4d83e1442640ef;p=karo-tx-linux.git dmaengine: sun6i: Remove switch statement from buswidth convertion routine Since the conversion routine is quite trivial, we don't need this switch, and we can just use a simple calculation. Signed-off-by: Maxime Ripard Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/sun6i-dma.c b/drivers/dma/sun6i-dma.c index c771d90b8ded..609c5d8cb947 100644 --- a/drivers/dma/sun6i-dma.c +++ b/drivers/dma/sun6i-dma.c @@ -248,20 +248,11 @@ static inline int convert_burst(u32 maxburst, u8 *burst) static inline int convert_buswidth(enum dma_slave_buswidth addr_width, u8 *width) { - switch (addr_width) { - case DMA_SLAVE_BUSWIDTH_1_BYTE: - *width = 0; - break; - case DMA_SLAVE_BUSWIDTH_2_BYTES: - *width = 1; - break; - case DMA_SLAVE_BUSWIDTH_4_BYTES: - *width = 2; - break; - default: + if ((addr_width < DMA_SLAVE_BUSWIDTH_1_BYTE) || + (addr_width > DMA_SLAVE_BUSWIDTH_4_BYTES)) return -EINVAL; - } + *width = addr_width >> 1; return 0; }