From: Preston Fick Date: Wed, 16 Jul 2014 19:31:30 +0000 (-0500) Subject: USB: serial: cp210x: Removing unncessary `usb_reset_device` on startup X-Git-Tag: v3.17-rc1~121^2~28 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=934ef5aca9daea10507eebcbd0fb8f6d57d55359;p=karo-tx-linux.git USB: serial: cp210x: Removing unncessary `usb_reset_device` on startup This `usb_reset_device` command has been around since the driver was originally reverse engineered. It doesn't cause much issue on single interface CP210x devices, but on the CP2105 and CP2108 with 2 and 4 interfaces respectively it will cause instability on enumeration and delays enumeration noticably. There should be no reason to reset a device at startup, per the CP210x AN571 spec. Signed-off-by: Preston Fick Cc: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index 330df5ce435b..e4bb62225cb9 100644 --- a/drivers/usb/serial/cp210x.c +++ b/drivers/usb/serial/cp210x.c @@ -856,9 +856,6 @@ static int cp210x_startup(struct usb_serial *serial) struct usb_host_interface *cur_altsetting; struct cp210x_serial_private *spriv; - /* cp210x buffers behave strangely unless device is reset */ - usb_reset_device(serial->dev); - spriv = kzalloc(sizeof(*spriv), GFP_KERNEL); if (!spriv) return -ENOMEM;