From: Julia Lawall Date: Sat, 3 Nov 2012 10:58:36 +0000 (+0000) Subject: drivers/parisc/pdc_stable.c: use WARN X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=93c3e913e104c9277e32a0d7e03f268d146c57ee;p=linux-beck.git drivers/parisc/pdc_stable.c: use WARN Use WARN rather than printk followed by WARN_ON(1), for conciseness. Signed-off-by: Julia Lawall Signed-off-by: Helge Deller --- diff --git a/drivers/parisc/pdc_stable.c b/drivers/parisc/pdc_stable.c index 246a92f677e4..0f54ab6260df 100644 --- a/drivers/parisc/pdc_stable.c +++ b/drivers/parisc/pdc_stable.c @@ -212,12 +212,10 @@ pdcspath_store(struct pdcspath_entry *entry) entry, devpath, entry->addr); /* addr, devpath and count must be word aligned */ - if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) { - printk(KERN_ERR "%s: an error occurred when writing to PDC.\n" + if (pdc_stable_write(entry->addr, devpath, sizeof(*devpath)) != PDC_OK) + WARN(1, KERN_ERR "%s: an error occurred when writing to PDC.\n" "It is likely that the Stable Storage data has been corrupted.\n" "Please check it carefully upon next reboot.\n", __func__); - WARN_ON(1); - } /* kobject is already registered */ entry->ready = 2;