From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Fri, 21 Jul 2017 21:48:06 +0000 (+0300)
Subject: platform/x86: wmi: Fix error handling in acpi_wmi_init()
X-Git-Tag: v4.13-rc4~26^2~1
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=972777171f33f9932f51feebe42dbcc1b475d01a;p=karo-tx-linux.git

platform/x86: wmi: Fix error handling in acpi_wmi_init()

The order of resource deallocations is messed up in acpi_wmi_init().
It should be vice versa.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
---

diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c
index 1a764e311e11..e32ba575e8d9 100644
--- a/drivers/platform/x86/wmi.c
+++ b/drivers/platform/x86/wmi.c
@@ -1252,12 +1252,12 @@ static int __init acpi_wmi_init(void)
 
 	return 0;
 
-err_unreg_class:
-	class_unregister(&wmi_bus_class);
-
 err_unreg_bus:
 	bus_unregister(&wmi_bus_type);
 
+err_unreg_class:
+	class_unregister(&wmi_bus_class);
+
 	return error;
 }