From: Christian Gromm Date: Fri, 19 Aug 2016 09:13:00 +0000 (+0200) Subject: staging: most: hdm-usb: remove unnecessary status assignment X-Git-Tag: v4.9-rc1~119^2~1020 X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9736fc0434f4b6ad257ae1a212e4e82336b66615;p=karo-tx-linux.git staging: most: hdm-usb: remove unnecessary status assignment The USB completion callbacks set the status field of an MBO object before scheduling the clear_work. This patch removes this redundant assignment as the work_struct does the same for all MBOs. Signed-off-by: Andrey Shvetsov Signed-off-by: Christian Gromm Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c index 453b641684d4..f44f27e647ea 100644 --- a/drivers/staging/most/hdm-usb/hdm_usb.c +++ b/drivers/staging/most/hdm-usb/hdm_usb.c @@ -412,7 +412,6 @@ static void hdm_write_completion(struct urb *urb) dev_warn(dev, "Broken OUT pipe detected\n"); mdev->is_channel_healthy[channel] = false; spin_unlock_irqrestore(lock, flags); - mbo->status = MBO_E_INVAL; mdev->clear_work[channel].pipe = urb->pipe; schedule_work(&mdev->clear_work[channel].ws); return; @@ -570,7 +569,6 @@ static void hdm_read_completion(struct urb *urb) dev_warn(dev, "Broken IN pipe detected\n"); mdev->is_channel_healthy[channel] = false; spin_unlock_irqrestore(lock, flags); - mbo->status = MBO_E_INVAL; mdev->clear_work[channel].pipe = urb->pipe; schedule_work(&mdev->clear_work[channel].ws); return;