From: Viresh Kumar Date: Mon, 19 Aug 2013 14:44:14 +0000 (+0530) Subject: tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=97f2c4289c591c2f24fb4a4cc03d78a0bef93187;p=linux-beck.git tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then tty_flip_buffer_push() immediately after that. But last statement of __serial_lpc32xx_rx() already called tty_flip_buffer_push().. So, probably its not required to be called twice. Lets remove one of them. Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index dffea6b2cd7d..8fdf6a8fc074 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -351,10 +351,8 @@ static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id) } /* Data received? */ - if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) { + if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) __serial_lpc32xx_rx(port); - tty_flip_buffer_push(tport); - } /* Transmit data request? */ if ((status & LPC32XX_HSU_TX_INT) && (!uart_tx_stopped(port))) {