From: Peter Huewe Date: Mon, 13 May 2013 21:41:48 +0000 (+0200) Subject: staging/xgifb: Remove unnecessary binary calculation in GetXG27FPBits X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=986eb9fad5da8bc498eb9d15d61efae4c4c407c1;p=linux-beck.git staging/xgifb: Remove unnecessary binary calculation in GetXG27FPBits If temp <= 2 no other bits than the lowest two (0x03) can be set anyway -> this operation can be removed. Signed-off-by: Peter Huewe Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c index ba8796fb66d6..090c424d4670 100644 --- a/drivers/staging/xgifb/vb_init.c +++ b/drivers/staging/xgifb/vb_init.c @@ -1177,9 +1177,7 @@ static unsigned char GetXG27FPBits(struct vb_device_info *pVBInfo) /* enable GPIOA/B/C read */ xgifb_reg_and_or(pVBInfo->P3d4, 0x4A, ~0x03, 0x03); temp = xgifb_reg_get(pVBInfo->P3d4, 0x48); - if (temp <= 2) - temp &= 0x03; - else + if (temp > 2) temp = ((temp & 0x04) >> 1) | ((~temp) & 0x01); xgifb_reg_set(pVBInfo->P3d4, 0x4A, CR4A);