From: Dan Carpenter Date: Fri, 8 Jul 2011 07:25:40 +0000 (+0300) Subject: Staging: tm6000: remove unneeded check in get_next_buf() X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=98c0a9c9badedd52f558f7657572e094c3d1c6e5;p=linux-beck.git Staging: tm6000: remove unneeded check in get_next_buf() We dereference "buf" on the line before so if it were NULL here we would have OOPsed earlier. Also list_entry() never returns NULL. And finally, we handled the situation where the list is empty earlier in the function. So this test isn't needed and I've removed it. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/tm6000/tm6000-video.c b/drivers/staging/tm6000/tm6000-video.c index 3fe603858f8f..8d8b939915d8 100644 --- a/drivers/staging/tm6000/tm6000-video.c +++ b/drivers/staging/tm6000/tm6000-video.c @@ -179,9 +179,6 @@ static inline void get_next_buf(struct tm6000_dmaqueue *dma_q, *buf = list_entry(dma_q->active.next, struct tm6000_buffer, vb.queue); - if (!buf) - return; - /* Cleans up buffer - Useful for testing for frame/URB loss */ outp = videobuf_to_vmalloc(&(*buf)->vb);