From: Peter Hurley <peter@hurleysoftware.com>
Date: Sun, 8 Nov 2015 18:01:08 +0000 (-0500)
Subject: tty: Improve tty_debug() macro
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=998b4a4571b87eb6795863e07683fa5d4e0398ba;p=linux-beck.git

tty: Improve tty_debug() macro

Incorporate suggestions for tty core debug macro improvements
 - printk(KERN_DEBUG) => pr_debug()
 - ##args => ##__VA_ARGS__
 - remove do {} while()
 - output tty_name() first

cc: Joe Perches <joe@perches.com>
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/include/linux/tty.h b/include/linux/tty.h
index 5e31f1b99037..3695c884258a 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -667,10 +667,7 @@ static inline void proc_tty_register_driver(struct tty_driver *d) {}
 static inline void proc_tty_unregister_driver(struct tty_driver *d) {}
 #endif
 
-#define tty_debug(tty, f, args...)					\
-	do {								\
-		printk(KERN_DEBUG "%s: %s: " f, __func__,		\
-		       tty_name(tty), ##args);				\
-	} while (0)
+#define tty_debug(tty, f, ...) \
+	pr_debug("%s: %s: " f, tty_name(tty), __func__, ##__VA_ARGS__)
 
 #endif