From: Lars-Peter Clausen <lars@metafoo.de>
Date: Thu, 31 Jan 2013 14:27:00 +0000 (+0000)
Subject: staging:iio:adxrs450: Reject out of range calibscale values
X-Git-Url: https://git.karo-electronics.de/?a=commitdiff_plain;h=9a26578c811e6f4de24d81ef734b17c401e5080f;p=linux-beck.git

staging:iio:adxrs450: Reject out of range calibscale values

Instead of silently discarding the upper bits reject out of range values for the
calibscale property.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/staging/iio/gyro/adxrs450_core.c b/drivers/staging/iio/gyro/adxrs450_core.c
index 4c462d36dac9..96e52844377b 100644
--- a/drivers/staging/iio/gyro/adxrs450_core.c
+++ b/drivers/staging/iio/gyro/adxrs450_core.c
@@ -258,9 +258,10 @@ static int adxrs450_write_raw(struct iio_dev *indio_dev,
 	int ret;
 	switch (mask) {
 	case IIO_CHAN_INFO_CALIBBIAS:
+		if (val < -0x400 || val >= 0x400)
+			return -EINVAL;
 		ret = adxrs450_spi_write_reg_16(indio_dev,
-						ADXRS450_DNC1,
-						val & 0x3FF);
+						ADXRS450_DNC1, val);
 		break;
 	default:
 		ret = -EINVAL;